linux-kernel - Re: [PATCH] dt-bindings: extcon: linux,extcon-usb-gpio: GPIO must be provided

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250331-heading-automaker-8c2d28fb4206@spud>
Date: Mon, 31 Mar 2025 16:52:49 +0100
From: Conor Dooley <conor@...nel.org>
To: david@...t.cz
Cc: MyungJoo Ham <myungjoo.ham@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Frank Li <Frank.Li@....com>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: extcon: linux,extcon-usb-gpio: GPIO must be
 provided

On Sat, Mar 29, 2025 at 01:09:47PM +0100, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@...t.cz>
> 
> Without providing either ID or VBUS GPIO the driver is not able to operate.
> Original text binding says:
>   "Either one of id-gpio or vbus-gpio must be present."

The next sentence in the old binding reads something like "both can be
present as well", so the anyOf below is correct.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

> 
> Fixes: 79a31ce03f41 ("dt-bindings: extcon: convert extcon-usb-gpio.txt to yaml format")
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
>  Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml b/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
> index 8856107bdd33b8654812ab9c97e85e23dc2ef75a..8f29d333602b95fe5ccd8464aa64e2d1f0c1c781 100644
> --- a/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
> +++ b/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
> @@ -25,6 +25,12 @@ properties:
>  required:
>    - compatible
>  
> +anyOf:
> +  - required:
> +      - id-gpios
> +  - required:
> +      - vbus-gpios
> +
>  additionalProperties: false
>  
>  examples:
> 
> ---
> base-commit: e21edb1638e82460f126a6e49bcdd958d452929c
> change-id: 20250329-yaml-extcon-usb-gpio-251b66522287
> 
> Best regards,
> -- 
> David Heidelberg <david@...t.cz>
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)