| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1EC996B6-31CE-4548-8822-4E6B6FCE3C6B@inria.fr>
Date: Mon, 31 Mar 2025 18:01:19 +0200
From: Julia Lawall <Julia.Lawall@...ia.fr>
To: Erick Karanja <karanja99erick@...il.com>
Cc: gregkh@...uxfoundation.org, outreachy@...ts.linux.dev,
philipp.g.hortmann@...il.com, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org, Erick Karanja <karanja99erick@...il.com>
Subject: Re: [PATCH 4/5] staging: rtl8723bs: no space before tabs
> On 31 Mar 2025, at 17:47, Erick Karanja <karanja99erick@...il.com> wrote:
>
> Remove spaces before tabs to comply with the Linux kernel coding style
> guidelines. Proper indentation using tabs improves code consistency
> and readability.
In a lot of cases you are removing comments that contain code. You can also just remove these comments.
Julia
>
> Reported by checkpatch:
>
> WARNING: please, no space before tabs
>
> Signed-off-by: Erick Karanja <karanja99erick@...il.com>
> ---
> drivers/staging/rtl8723bs/hal/hal_btcoex.c | 42 +++++++++++-----------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index 9105594d2dde..b0e023d0435c 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -9,14 +9,14 @@
> #include <hal_btcoex.h>
> #include <Mp_Precomp.h>
>
> -/* Global variables */
> +/*Global variables */
>
> struct btc_coexist GLBtCoexist;
> static u8 GLBtcWiFiInScanState;
> static u8 GLBtcWiFiInIQKState;
>
> /* */
> -/* Debug related function */
> +/*Debug related function */
> /* */
> static u8 halbtcoutsrc_IsBtCoexistAvailable(struct btc_coexist *pBtCoexist)
> {
> @@ -401,9 +401,9 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getType, void *pOutBuf)
>
> case BTC_GET_U1_MAC_PHY_MODE:
> *pu8 = BTC_SMSP;
> -/* *pU1Tmp = BTC_DMSP; */
> -/* *pU1Tmp = BTC_DMDP; */
> -/* *pU1Tmp = BTC_MP_UNKNOWN; */
> +/* *pU1Tmp = BTC_DMSP; */
> +/* *pU1Tmp = BTC_DMDP; */
> +/* *pU1Tmp = BTC_MP_UNKNOWN; */
> break;
>
> case BTC_GET_U1_AP_NUM:
> @@ -561,7 +561,7 @@ static u8 halbtcoutsrc_Set(void *pBtcContext, u8 setType, void *pInBuf)
> }
>
> /* */
> -/* IO related function */
> +/* IO related function */
> /* */
> static u8 halbtcoutsrc_Read1Byte(void *pBtcContext, u32 RegAddr)
> {
> @@ -772,7 +772,7 @@ static void halbtcoutsrc_FillH2cCmd(void *pBtcContext, u8 elementId, u32 cmdLen,
> }
>
> /* */
> -/* Extern functions called by other module */
> +/* Extern functions called by other module */
> /* */
> static u8 EXhalbtcoutsrc_BindBtCoexWithAdapter(void *padapter)
> {
> @@ -900,14 +900,14 @@ void EXhalbtcoutsrc_IpsNotify(struct btc_coexist *pBtCoexist, u8 type)
> ipsType = BTC_IPS_ENTER;
>
> /* All notify is called in cmd thread, don't need to leave low power again */
> -/* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
> + /* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
> if (pBtCoexist->boardInfo.btdmAntNum == 2)
> EXhalbtc8723b2ant_IpsNotify(pBtCoexist, ipsType);
> else if (pBtCoexist->boardInfo.btdmAntNum == 1)
> EXhalbtc8723b1ant_IpsNotify(pBtCoexist, ipsType);
>
> -/* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> + /* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> }
>
> void EXhalbtcoutsrc_LpsNotify(struct btc_coexist *pBtCoexist, u8 type)
> @@ -952,14 +952,14 @@ void EXhalbtcoutsrc_ScanNotify(struct btc_coexist *pBtCoexist, u8 type)
> }
>
> /* All notify is called in cmd thread, don't need to leave low power again */
> -/* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
> + /* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
> if (pBtCoexist->boardInfo.btdmAntNum == 2)
> EXhalbtc8723b2ant_ScanNotify(pBtCoexist, scanType);
> else if (pBtCoexist->boardInfo.btdmAntNum == 1)
> EXhalbtc8723b1ant_ScanNotify(pBtCoexist, scanType);
>
> -/* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> + /* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> }
>
> void EXhalbtcoutsrc_ConnectNotify(struct btc_coexist *pBtCoexist, u8 action)
> @@ -978,14 +978,14 @@ void EXhalbtcoutsrc_ConnectNotify(struct btc_coexist *pBtCoexist, u8 action)
> assoType = BTC_ASSOCIATE_FINISH;
>
> /* All notify is called in cmd thread, don't need to leave low power again */
> -/* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
> + /* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
> if (pBtCoexist->boardInfo.btdmAntNum == 2)
> EXhalbtc8723b2ant_ConnectNotify(pBtCoexist, assoType);
> else if (pBtCoexist->boardInfo.btdmAntNum == 1)
> EXhalbtc8723b1ant_ConnectNotify(pBtCoexist, assoType);
>
> -/* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> + /* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> }
>
> void EXhalbtcoutsrc_MediaStatusNotify(struct btc_coexist *pBtCoexist, enum
> @@ -1006,14 +1006,14 @@ void EXhalbtcoutsrc_MediaStatusNotify(struct btc_coexist *pBtCoexist, enum
> mStatus = BTC_MEDIA_DISCONNECT;
>
> /* All notify is called in cmd thread, don't need to leave low power again */
> -/* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
> + /* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
> if (pBtCoexist->boardInfo.btdmAntNum == 2)
> EXhalbtc8723b2ant_MediaStatusNotify(pBtCoexist, mStatus);
> else if (pBtCoexist->boardInfo.btdmAntNum == 1)
> EXhalbtc8723b1ant_MediaStatusNotify(pBtCoexist, mStatus);
>
> -/* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> + /* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> }
>
> void EXhalbtcoutsrc_SpecialPacketNotify(struct btc_coexist *pBtCoexist, u8 pktType)
> @@ -1037,14 +1037,14 @@ void EXhalbtcoutsrc_SpecialPacketNotify(struct btc_coexist *pBtCoexist, u8 pktTy
> }
>
> /* All notify is called in cmd thread, don't need to leave low power again */
> -/* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
> + /* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
> if (pBtCoexist->boardInfo.btdmAntNum == 2)
> EXhalbtc8723b2ant_SpecialPacketNotify(pBtCoexist, packetType);
> else if (pBtCoexist->boardInfo.btdmAntNum == 1)
> EXhalbtc8723b1ant_SpecialPacketNotify(pBtCoexist, packetType);
>
> -/* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> + /* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> }
>
> void EXhalbtcoutsrc_BtInfoNotify(struct btc_coexist *pBtCoexist, u8 *tmpBuf, u8 length)
> @@ -1055,14 +1055,14 @@ void EXhalbtcoutsrc_BtInfoNotify(struct btc_coexist *pBtCoexist, u8 *tmpBuf, u8
> pBtCoexist->statistics.cntBtInfoNotify++;
>
> /* All notify is called in cmd thread, don't need to leave low power again */
> -/* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
> + /* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
> if (pBtCoexist->boardInfo.btdmAntNum == 2)
> EXhalbtc8723b2ant_BtInfoNotify(pBtCoexist, tmpBuf, length);
> else if (pBtCoexist->boardInfo.btdmAntNum == 1)
> EXhalbtc8723b1ant_BtInfoNotify(pBtCoexist, tmpBuf, length);
>
> -/* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> + /* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> }
>
> void EXhalbtcoutsrc_HaltNotify(struct btc_coexist *pBtCoexist)
> @@ -1102,14 +1102,14 @@ void EXhalbtcoutsrc_Periodical(struct btc_coexist *pBtCoexist)
>
> /* Periodical should be called in cmd thread, */
> /* don't need to leave low power again */
> -/* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
> + /* halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
> if (pBtCoexist->boardInfo.btdmAntNum == 2)
> EXhalbtc8723b2ant_Periodical(pBtCoexist);
> else if (pBtCoexist->boardInfo.btdmAntNum == 1)
> EXhalbtc8723b1ant_Periodical(pBtCoexist);
>
> -/* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> + /* halbtcoutsrc_NormalLowPower(pBtCoexist); */
> }
>
> void EXhalbtcoutsrc_SetAntNum(u8 type, u8 antNum)
> --
> 2.43.0
>
>
Powered by blists - more mailing lists