linux-kernel - [PATCH] wifi: iwlwifi: mld: Fix build with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250401032153.2896424-1-linux@roeck-us.net>
Date: Mon, 31 Mar 2025 20:21:53 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Johannes Berg <johannes.berg@...el.com>
Cc: linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>,
	Miri Korenblit <miriam.rachel.korenblit@...el.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: [PATCH] wifi: iwlwifi: mld: Fix build with CONFIG_PM disabled

If CONFIG_PM is disabled, the CONFIG_PM symbol is not defined.
This results in

drivers/net/wireless/intel/iwlwifi/mld/iface.h:169:5: error:
	"CONFIG_PM_SLEEP" is not defined, evaluates to 0

because the conditional uses #if instead of #ifdef. Using #ifdef
fixes the problem.

Fixes: d1e879ec600f9 ("wifi: iwlwifi: add iwlmld sub-driver")
Cc: Miri Korenblit <miriam.rachel.korenblit@...el.com>
Cc: Arnd Bergmann <arnd@...db.de>
Signed-off-by: Guenter Roeck <linux@...ck-us.net>
---
Maybe this has already been addressed. If so, sorry, I did not find it.
I did not see thos fixed in Arnd's patch addressing the other PM_SLEEP
related issues in the driver.

 drivers/net/wireless/intel/iwlwifi/mld/iface.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mld/iface.h b/drivers/net/wireless/intel/iwlwifi/mld/iface.h
index d1d56b081bf6..ec14d0736cee 100644
--- a/drivers/net/wireless/intel/iwlwifi/mld/iface.h
+++ b/drivers/net/wireless/intel/iwlwifi/mld/iface.h
@@ -166,7 +166,7 @@ struct iwl_mld_vif {
 
 	struct iwl_mld_emlsr emlsr;
 
-#if CONFIG_PM_SLEEP
+#ifdef CONFIG_PM_SLEEP
 	struct iwl_mld_wowlan_data wowlan_data;
 #endif
 #ifdef CONFIG_IWLWIFI_DEBUGFS
-- 
2.45.2