linux-kernel - Re: [PATCH] wifi: iwlwifi: mld: Fix build with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a5147038b771980b87761a75be38e1d9d43d1fa.camel@sipsolutions.net>
Date: Tue, 01 Apr 2025 08:56:40 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Guenter Roeck <linux@...ck-us.net>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, Miri
 Korenblit <miriam.rachel.korenblit@...el.com>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] wifi: iwlwifi: mld: Fix build with CONFIG_PM disabled

On Mon, 2025-03-31 at 20:21 -0700, Guenter Roeck wrote:
> If CONFIG_PM is disabled, the CONFIG_PM symbol is not defined.
> This results in
> 
> drivers/net/wireless/intel/iwlwifi/mld/iface.h:169:5: error:
> 	"CONFIG_PM_SLEEP" is not defined, evaluates to 0
> 
> because the conditional uses #if instead of #ifdef. Using #ifdef
> fixes the problem.
> 
> Fixes: d1e879ec600f9 ("wifi: iwlwifi: add iwlmld sub-driver")
> Cc: Miri Korenblit <miriam.rachel.korenblit@...el.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> Maybe this has already been addressed. If so, sorry, I did not find it.
> I did not see thos fixed in Arnd's patch addressing the other PM_SLEEP
> related issues in the driver.
> 

Hadn't, except internally I'd fixed it a while ago, and now Miri sent my
patch (same as yours) 20 minutes later ;-)

Thanks, I'll start getting things into the wireless tree soon.

johannes