linux-kernel - Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58f9fd5d7d0758c4877d3e0c70f63af49e211ce3.camel@intel.com>
Date: Tue, 1 Apr 2025 08:08:41 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "Mehta, Sohil" <sohil.mehta@...el.com>, "mingo@...hat.com"
	<mingo@...hat.com>
CC: "Luck, Tony" <tony.luck@...el.com>, "Nikula, Jani"
	<jani.nikula@...el.com>, "x86@...nel.org" <x86@...nel.org>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"peterz@...radead.org" <peterz@...radead.org>, "hpa@...or.com"
	<hpa@...or.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kirill.shutemov@...ux.intel.com"
	<kirill.shutemov@...ux.intel.com>, "bp@...en8.de" <bp@...en8.de>,
	"bigeasy@...utronix.de" <bigeasy@...utronix.de>, "rppt@...nel.org"
	<rppt@...nel.org>, "jpoimboe@...nel.org" <jpoimboe@...nel.org>,
	"xin@...or.com" <xin@...or.com>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"pmladek@...e.com" <pmladek@...e.com>
Subject: Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

On Mon, 2025-03-31 at 22:46 -0700, Sohil Mehta wrote:
> On 3/31/2025 6:06 PM, Huang, Kai wrote:
> 
> > > > Ah I didn't know this series was merged.  I think I'll stop looking at it.  :-)
> > > 
> > > Your review comments have been useful. Please continue reviewing if you
> > > can. You found an issue in patch 1 that both of us missed.
> > > 
> > 
> > I just did.  I didn't find anything apart from one thing that I _think_ it might
> > be helpful to mention another commit in the changelog of patch 5 "x86/nmi: Fix
> > comment in unknown NMI handling".
> > 
> 
> Kai, I feel the additional commit is indirectly implied. I am inclined
> to leave the changelog as-is unless you feel strongly about it.

Sure np to me.