linux-kernel - Re: [PATCH 0/9] x86: Cleanup NMI handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250401145425.GK5880@noisy.programming.kicks-ass.net>
Date: Tue, 1 Apr 2025 16:54:25 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Sohil Mehta <sohil.mehta@...el.com>
Cc: x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H . Peter Anvin" <hpa@...or.com>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
	Kai Huang <kai.huang@...el.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Mike Rapoport <rppt@...nel.org>, Petr Mladek <pmladek@...e.com>,
	Jani Nikula <jani.nikula@...el.com>,
	Tony Luck <tony.luck@...el.com>, Xin Li <xin@...or.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/9] x86: Cleanup NMI handling

On Thu, Mar 27, 2025 at 11:46:20PM +0000, Sohil Mehta wrote:

> Sohil Mehta (9):
>   x86/nmi: Simplify unknown NMI panic handling
>   x86/nmi: Consolidate NMI panic variables
>   x86/nmi: Use a macro to initialize NMI descriptors
>   x86/nmi: Remove export of local_touch_nmi()
>   x86/nmi: Fix comment in unknown NMI handling
>   x86/nmi: Improve and relocate NMI handler comments
>   x86/nmi: Improve NMI header documentation
>   x86/nmi: Clean up NMI selftest
>   x86/nmi: Improve NMI duration console print
> 
>  arch/x86/include/asm/nmi.h      | 49 +++++++++++++++++--
>  arch/x86/include/asm/x86_init.h |  1 +
>  arch/x86/kernel/dumpstack.c     |  2 -
>  arch/x86/kernel/nmi.c           | 87 ++++++++++++++++-----------------
>  arch/x86/kernel/nmi_selftest.c  | 52 ++++++--------------
>  arch/x86/kernel/setup.c         | 37 ++++++--------
>  include/linux/panic.h           |  2 -
>  7 files changed, 122 insertions(+), 108 deletions(-)

These seem sane,

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>