linux-kernel - Re: [PATCH] crypto: Kconfig - correct references in config CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-vZKlqdAtvyeUjj@gondor.apana.org.au>
Date: Tue, 1 Apr 2025 20:16:42 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Lukas Bulwahn <lbulwahn@...hat.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Hannes Reinecke <hare@...nel.org>, Keith Busch <kbusch@...nel.org>,
	Eric Biggers <ebiggers@...nel.org>, linux-crypto@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	Lukas Bulwahn <lukas.bulwahn@...hat.com>
Subject: Re: [PATCH] crypto: Kconfig - correct references in config
 CRYPTO_HKDF

On Tue, Apr 01, 2025 at 02:13:54PM +0200, Lukas Bulwahn wrote:
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index dbf97c4e7c59..f601a4ec6d1a 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -143,8 +143,8 @@ config CRYPTO_ACOMP
>  
>  config CRYPTO_HKDF
>  	tristate
> -	select CRYPTO_SHA256 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
> -	select CRYPTO_SHA512 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
> +	select CRYPTO_SHA256 if !CRYPTO_MANAGER_DISABLE_TESTS
> +	select CRYPTO_SHA512 if !CRYPTO_MANAGER_DISABLE_TESTS

Why not just drop CRYPTO_MANAGER_DISABLE_TESTS and select the
SHA algorithms unconditionally?

>  	select CRYPTO_HASH2

Nobody should select HASH2.  Just drop it since it's implied
by SHA256/SHA512.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt