| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d9885697-25c2-4f2b-822d-444a10f0c78d@suse.de> Date: Wed, 2 Apr 2025 08:05:09 +0200 From: Hannes Reinecke <hare@...e.de> To: Herbert Xu <herbert@...dor.apana.org.au>, Lukas Bulwahn <lbulwahn@...hat.com> Cc: "David S . Miller" <davem@...emloft.net>, Hannes Reinecke <hare@...nel.org>, Keith Busch <kbusch@...nel.org>, Eric Biggers <ebiggers@...nel.org>, linux-crypto@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, Lukas Bulwahn <lukas.bulwahn@...hat.com> Subject: Re: [PATCH] crypto: Kconfig - correct references in config CRYPTO_HKDF On 4/1/25 14:16, Herbert Xu wrote: > On Tue, Apr 01, 2025 at 02:13:54PM +0200, Lukas Bulwahn wrote: >> >> diff --git a/crypto/Kconfig b/crypto/Kconfig >> index dbf97c4e7c59..f601a4ec6d1a 100644 >> --- a/crypto/Kconfig >> +++ b/crypto/Kconfig >> @@ -143,8 +143,8 @@ config CRYPTO_ACOMP >> >> config CRYPTO_HKDF >> tristate >> - select CRYPTO_SHA256 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS >> - select CRYPTO_SHA512 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS >> + select CRYPTO_SHA256 if !CRYPTO_MANAGER_DISABLE_TESTS >> + select CRYPTO_SHA512 if !CRYPTO_MANAGER_DISABLE_TESTS > > Why not just drop CRYPTO_MANAGER_DISABLE_TESTS and select the > SHA algorithms unconditionally? > Fine with me. I was just trying to follow precedent here when creating the original patch. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@...e.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Powered by blists - more mailing lists