linux-kernel - Re: [PATCH v1 1/1] usbnet:fix NPE during rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGo_G-f_8w9E388GOunNJ329W8UqOQ0y2amx_gMvbbstw4=H2A@mail.gmail.com>
Date: Tue, 1 Apr 2025 20:48:01 +0800
From: Ying Lu <luying526@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: oneukum@...e.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	netdev@...r.kernel.org, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org, luying1 <luying1@...omi.com>
Subject: Re: [PATCH v1 1/1] usbnet:fix NPE during rx_complete

On Tue, Apr 1, 2025 at 6:31 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Apr 01, 2025 at 06:18:01PM +0800, Ying Lu wrote:
> > From: luying1 <luying1@...omi.com>
> >
> > Missing usbnet_going_away Check in Critical Path.
> > The usb_submit_urb function lacks a usbnet_going_away
> > validation, whereas __usbnet_queue_skb includes this check.
> >
> > This inconsistency creates a race condition where:
> > A URB request may succeed, but the corresponding SKB data
> > fails to be queued.
> >
> > Subsequent processes:
> > (e.g., rx_complete → defer_bh → __skb_unlink(skb, list))
> > attempt to access skb->next, triggering a NULL pointer
> > dereference (Kernel Panic).
> >
> > Signed-off-by: luying1 <luying1@...omi.com>
>
> Please use your name, not an email alias.
>
OK, I have updated. please check the Patch v2

> Also, what commit id does this fix?  Should it be applied to stable
> kernels?
The commit  id is 04e906839a053f092ef53f4fb2d610983412b904
(usbnet: fix cyclical race on disconnect with work queue)
Should it be applied to stable kernels?  -- Yes

> thanks,
>
> greg k-h