[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025040110-unknowing-siding-c7d2@gregkh>
Date: Tue, 1 Apr 2025 11:29:53 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Ying Lu <luying526@...il.com>
Cc: oneukum@...e.com, andrew+netdev@...n.ch, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
netdev@...r.kernel.org, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, luying1 <luying1@...omi.com>
Subject: Re: [PATCH v1 1/1] usbnet:fix NPE during rx_complete
On Tue, Apr 01, 2025 at 06:18:01PM +0800, Ying Lu wrote:
> From: luying1 <luying1@...omi.com>
>
> Missing usbnet_going_away Check in Critical Path.
> The usb_submit_urb function lacks a usbnet_going_away
> validation, whereas __usbnet_queue_skb includes this check.
>
> This inconsistency creates a race condition where:
> A URB request may succeed, but the corresponding SKB data
> fails to be queued.
>
> Subsequent processes:
> (e.g., rx_complete → defer_bh → __skb_unlink(skb, list))
> attempt to access skb->next, triggering a NULL pointer
> dereference (Kernel Panic).
>
> Signed-off-by: luying1 <luying1@...omi.com>
Please use your name, not an email alias.
Also, what commit id does this fix? Should it be applied to stable
kernels?
thanks,
greg k-h
Powered by blists - more mailing lists