linux-kernel - Re: [PATCH bpf] bpf: add missing ops lock around dev_xdp_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2914c9f-5fc6-4719-bf6b-bc48991cd563@redhat.com>
Date: Tue, 1 Apr 2025 12:33:09 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Stanislav Fomichev <sdf@...ichev.me>, bpf@...r.kernel.org,
 netdev@...r.kernel.org
Cc: ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
 martin.lau@...ux.dev, song@...nel.org, yhs@...com, john.fastabend@...il.com,
 kpsingh@...nel.org, haoluo@...gle.com, jolsa@...nel.org,
 linux-kernel@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, horms@...nel.org, hawk@...nel.org,
 syzbot+08936936fe8132f91f1a@...kaller.appspotmail.com
Subject: Re: [PATCH bpf] bpf: add missing ops lock around dev_xdp_attach_link

On 3/31/25 4:28 PM, Stanislav Fomichev wrote:
> Syzkaller points out that create_link path doesn't grab ops lock,
> add it.
> 
> Cc: Jakub Kicinski <kuba@...nel.org>
> Reported-by: syzbot+08936936fe8132f91f1a@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/bpf/67e6b3e8.050a0220.2f068f.0079.GAE@google.com/
> Fixes: 97246d6d21c2 ("net: hold netdev instance lock during ndo_bpf")
> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>

LGTM, but are there any special reasons to get this via the bpf tree? It
looks like 'net' material to me?!?

Thanks,

Paolo