linux-kernel - Re: [PATCH bpf] bpf: add missing ops lock around dev_xdp_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJJFPD2X1enPCa-0D7RG6SraRFTdMj1bsKkzFuz6Nighw@mail.gmail.com>
Date: Tue, 1 Apr 2025 08:05:05 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Stanislav Fomichev <sdf@...ichev.me>, bpf <bpf@...r.kernel.org>, 
	Network Development <netdev@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>, 
	John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, 
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, 
	LKML <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>, 
	Jesper Dangaard Brouer <hawk@...nel.org>, syzbot+08936936fe8132f91f1a@...kaller.appspotmail.com
Subject: Re: [PATCH bpf] bpf: add missing ops lock around dev_xdp_attach_link

On Tue, Apr 1, 2025 at 3:33 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 3/31/25 4:28 PM, Stanislav Fomichev wrote:
> > Syzkaller points out that create_link path doesn't grab ops lock,
> > add it.
> >
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Reported-by: syzbot+08936936fe8132f91f1a@...kaller.appspotmail.com
> > Closes: https://lore.kernel.org/bpf/67e6b3e8.050a0220.2f068f.0079.GAE@google.com/
> > Fixes: 97246d6d21c2 ("net: hold netdev instance lock during ndo_bpf")
> > Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>
>
> LGTM, but are there any special reasons to get this via the bpf tree? It
> looks like 'net' material to me?!?

Pls take it through net.