linux-kernel - Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c39e5f6a-8e5b-496f-a284-74f7bc758ddd@kernel.org>
Date: Tue, 1 Apr 2025 17:04:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nam Tran <trannamatk@...il.com>, krzk+dt@...nel.org
Cc: pavel@...nel.org, lee@...nel.org, robh@...nel.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver

On 01/04/2025 16:29, Nam Tran wrote:
> On Mon, 31 Mar 2025, Krzysztof Kozlowski wrote:
> 
>> Please do not explain me how DT works, we all know. You do not have
>> child node. If you disagree - point me to the line in schema having it.
> 
> Thank you for your feedback.
> I now understand that my schema does not define child nodes, so #address-cells and #size-cells should not be included.
> I will update the schema accordingly as shown below.


This has... What are we talking here about? I commented only about that
patch.

You claimed:
>Nam: I included the #address-cells and #size-cells properties to
resolve a warning encountered when running:

which was obviously not true. You could not have such errors, because
you did not have children. You disagreed with me so you got response
like that.

If you decide to add children, then you will need address and size
cells, but that's a different patch.

Best regards,
Krzysztof