linux-kernel - Re: [PATCH v3] binder: use buffer offsets in debug logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-tNCasDwqtVZQOJ@google.com>
Date: Tue, 1 Apr 2025 02:18:49 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: "Tiffany Y. Yang" <ynaffit@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joel@...lfernandes.org>,
	Christian Brauner <brauner@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>,
	linux-kernel@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH v3] binder: use buffer offsets in debug logs

On Thu, Mar 27, 2025 at 11:17:09PM +0000, Tiffany Y. Yang wrote:
> Identify buffer addresses using vma offsets instead of full user
> addresses in debug logs or drop them if they are not useful.
> 
> Signed-off-by: Tiffany Y. Yang <ynaffit@...gle.com>
> ---

This looks good but there is one problem...

> @@ -4223,20 +4219,21 @@ static int binder_thread_write(struct binder_proc *proc,
>  			if (IS_ERR_OR_NULL(buffer)) {
>  				if (PTR_ERR(buffer) == -EPERM) {
>  					binder_user_error(
> -						"%d:%d BC_FREE_BUFFER u%016llx matched unreturned or currently freeing buffer\n",
> +						"%d:%d BC_FREE_BUFFER matched unreturned or currently freeing buffer at offset %lx\n",
>  						proc->pid, thread->pid,
> -						(u64)data_ptr);
> +						(unsigned long)data_ptr - proc->alloc.buffer);

The alloc.buffer should be alloc.vm_start, this was recently renamed. I
think you would need to rebase your tree.

--
Carlos Llamas