linux-kernel - Re: [PATCH v1 1/1] nvme: add admin controller support. prohibit ioq creation for admin & disco ctrlrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a54fab93-d48e-4095-89dc-97060652799a@nvidia.com>
Date: Tue, 1 Apr 2025 02:20:38 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Keith Busch <kbusch@...nel.org>, Kamaljit Singh <kamaljit.singh1@....com>
CC: "axboe@...nel.dk" <axboe@...nel.dk>, "hch@....de" <hch@....de>,
	"sagi@...mberg.me" <sagi@...mberg.me>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "niklas.cassel@....com"
	<niklas.cassel@....com>, "damien.lemoal@....com" <damien.lemoal@....com>
Subject: Re: [PATCH v1 1/1] nvme: add admin controller support. prohibit ioq
 creation for admin & disco ctrlrs

On 3/31/25 08:03, Keith Busch wrote:
> On Fri, Mar 28, 2025 at 02:36:40PM -0700, Kamaljit Singh wrote:
>> -static inline bool nvme_discovery_ctrl(struct nvme_ctrl *ctrl)
>> -{
>> -	return ctrl->opts && ctrl->opts->discovery_nqn;
>> -}
>> -
> I suppose it's fine to rename this function with an nvmf_ prefix, but
> it's not really related to the rest of the patch and makes the diff
> larger than necessary.

perhaps consider making a separate patch ...

-ck