linux-kernel - Re: [PATCH] bcachefs: use library APIs for ChaCha20 and Poly1305

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <264qspa55jt3rzkpfx6g2zx7dpcihsqolkui2ljr5zukpyr6xp@4eds66ahp543>
Date: Wed, 2 Apr 2025 12:33:54 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-crypto@...r.kernel.org, "Jason A . Donenfeld" <Jason@...c4.com>
Subject: Re: [PATCH] bcachefs: use library APIs for ChaCha20 and Poly1305

On Wed, Apr 02, 2025 at 09:28:47AM -0700, Eric Biggers wrote:
> On Wed, Apr 02, 2025 at 10:01:07AM -0400, Kent Overstreet wrote:
> > On Tue, Apr 01, 2025 at 09:33:33PM -0700, Eric Biggers wrote:
> > > From: Eric Biggers <ebiggers@...gle.com>
> > > 
> > > Just use the ChaCha20 and Poly1305 libraries instead of the clunky
> > > crypto API.  This is much simpler.  It is also slightly faster, since
> > > the libraries provide more direct access to the same
> > > architecture-optimized ChaCha20 and Poly1305 code.
> > > 
> > > I've tested that existing encrypted bcachefs filesystems can be continue
> > > to be accessed with this patch applied.
> > > 
> > > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> > 
> > Fantastic!
> > 
> > Applied, and this should go into 6.15 - this should get the strange bugs
> > in the poly1305 path that I wasn't able to reproduce off the dashboard
> > (and if they're still there, they'll be much easier to debug.)
> 
> Thanks!
> 
> If you're referring to
> https://lore.kernel.org/r/CAHOo4gLWAbArwg+w+AqqkxGmOFX6cm8Tvy85tb4igN6V7Z9BZQ@mail.gmail.com/,
> I think bcachefs passed invalid memory to Poly1305 as a result of mounting a
> fuzzed filesystem image.  So it should be unaffected by this patch.

Well, in that case your patch should still get us a backtrace that I can
actually debug :)