[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250402163402.GD342109@nvidia.com>
Date: Wed, 2 Apr 2025 13:34:02 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>,
Masahiro Yamada <masahiroy@...nel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Dave Airlie <airlied@...il.com>,
dri-devel <dri-devel@...ts.freedesktop.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] drm for 6.15-rc1
On Wed, Apr 02, 2025 at 04:41:44PM +0200, Simona Vetter wrote:
> - Gradually roll this out, ideally with support in main Kbuild so it
> doesn't have to be replicated.
No one said flag day, you'd have to approach the same way everyone
else has done when adding new compiler errors and warnings to the
build. An off-by-default option to produce the new errors/warnings,
and alot of time and fixes before the new tests become on by default.
The stuff like this is not really sensible:
+header-check-$(CONFIG_DRM_I915_WERROR) += \
+ $(filter-out $(no-header-test),$(shell cd $(src) && find * -name '*.h'))
Not only should we not be using globs to read the source files in a
build system, but it is brutal to have to list every header file in
the build in the makefiles, along with some kconfig :\
( also find is usually spelled $(wildcard $(src)/*.h) )
Jason
Powered by blists - more mailing lists