lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8bb290ee-615a-4e88-b7d4-776239c07ae7@web.de>
Date: Wed, 2 Apr 2025 20:46:48 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Henry Martin <bsdhenrymartin@...il.com>, netdev@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Michael Grzeschik <m.grzeschik@...gutronix.de>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH v3] arcnet: Add NULL check in com20020pci_probe()

…
> Add NULL check after devm_kasprintf() to prevent this issue and ensure
> no resources are left allocated.

I hope that further refinement possibilities can be taken better into account.


…
> ---
> V2 -> V3: Reuse label err_free_arcdev for exception handing.
…
> +++ b/drivers/net/arcnet/com20020-pci.c
> @@ -251,18 +251,33 @@ static int com20020pci_probe(struct pci_dev *pdev,
>  			card->tx_led.default_trigger = devm_kasprintf(&pdev->dev,
>  							GFP_KERNEL, "arc%d-%d-tx",
>  							dev->dev_id, i);
> +			if (!card->tx_led.default_trigger) {
> +				ret = -ENOMEM;
> +				goto err_free_arcdev;
> +			}
…

I propose to avoid duplicate source code also for the shown completion of
the corresponding exception handling.
https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources#MEM12C.Considerusingagotochainwhenleavingafunctiononerrorwhenusingandreleasingresources-CompliantSolution(copy_process()fromLinuxkernel)

See also once more:
* https://lore.kernel.org/linux-kernel/?q=e_nomem

* https://docs.kernel.org/process/maintainer-netdev.html

Regards,
Markus

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ