linux-kernel - Re: [PATCH net 3/7] net: hibmcge: fix the share of irq statistics among different network ports issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250402185726.GW214849@horms.kernel.org>
Date: Wed, 2 Apr 2025 19:57:26 +0100
From: Simon Horman <horms@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, shenjian15@...wei.com,
	wangpeiyang1@...wei.com, liuyonglong@...wei.com,
	chenhao418@...wei.com, jonathan.cameron@...wei.com,
	shameerali.kolothum.thodi@...wei.com, salil.mehta@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 3/7] net: hibmcge: fix the share of irq statistics
 among different network ports issue

On Wed, Apr 02, 2025 at 09:39:01PM +0800, Jijie Shao wrote:
> hbg_irqs is a global array which contains irq statistics.
> However, the irq statistics of different network ports
> point to the same global array. As a result, the statistics are incorrect.
> 
> This patch allocates a statistics array for each network port
> to prevent the statistics of different network ports
> from affecting each other.
> 
> irq statistics are removed from hbg_irq_info. Therefore,
> all data in hbg_irq_info remains unchanged. Therefore,
> the input parameter of some functions is changed to const.
> 
> Fixes: 4d089035fa19 ("net: hibmcge: Add interrupt supported in this module")
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>