[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250402185813.GX214849@horms.kernel.org>
Date: Wed, 2 Apr 2025 19:58:13 +0100
From: Simon Horman <horms@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, andrew+netdev@...n.ch, shenjian15@...wei.com,
wangpeiyang1@...wei.com, liuyonglong@...wei.com,
chenhao418@...wei.com, jonathan.cameron@...wei.com,
shameerali.kolothum.thodi@...wei.com, salil.mehta@...wei.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 4/7] net: hibmcge: fix wrong mtu log issue
On Wed, Apr 02, 2025 at 09:39:02PM +0800, Jijie Shao wrote:
> A dbg log is generated when the driver modifies the MTU,
> which is expected to trace the change of the MTU.
>
> However, the log is recorded after WRITE_ONCE().
> At this time, netdev->mtu has been changed to the new value.
> As a result, netdev->mtu is the same as new_mtu.
>
> This patch modifies the log location and records logs before WRITE_ONCE().
>
> Fixes: ff4edac6e9bd ("net: hibmcge: Implement some .ndo functions")
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists