linux-kernel - Re: [PATCH net 5/7] net: hibmcge: fix the incorrect np

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250402190452.GY214849@horms.kernel.org>
Date: Wed, 2 Apr 2025 20:04:52 +0100
From: Simon Horman <horms@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, shenjian15@...wei.com,
	wangpeiyang1@...wei.com, liuyonglong@...wei.com,
	chenhao418@...wei.com, jonathan.cameron@...wei.com,
	shameerali.kolothum.thodi@...wei.com, salil.mehta@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 5/7] net: hibmcge: fix the incorrect np_link fail
 state issue.

On Wed, Apr 02, 2025 at 09:39:03PM +0800, Jijie Shao wrote:
> In the debugfs file, the driver displays the np_link fail state
> based on the HBG_NIC_STATE_NP_LINK_FAIL.
> 
> However, HBG_NIC_STATE_NP_LINK_FAIL is cleared in hbg_service_task()
> So, this value of np_link fail is always false.
> 
> This patch directly reads the related register to display the real state.
> 
> Fixes: e0306637e85d ("net: hibmcge: Add support for mac link exception handling feature")
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>