linux-kernel - Re: [PATCH v2] zsmalloc: prefer the the original page's node for compressed data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67edc6af95e8e_1c2c62941a@dwillia2-xfh.jf.intel.com.notmuch>
Date: Wed, 2 Apr 2025 16:22:23 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Nhat Pham <nphamcs@...il.com>, Dan Williams <dan.j.williams@...el.com>
CC: <akpm@...ux-foundation.org>, <hannes@...xchg.org>,
	<yosry.ahmed@...ux.dev>, <chengming.zhou@...ux.dev>, <sj@...nel.org>,
	<linux-mm@...ck.org>, <kernel-team@...a.com>, <linux-kernel@...r.kernel.org>,
	<gourry@...rry.net>, <ying.huang@...ux.alibaba.com>,
	<jonathan.cameron@...wei.com>, <linux-cxl@...r.kernel.org>,
	<minchan@...nel.org>, <senozhatsky@...omium.org>
Subject: Re: [PATCH v2] zsmalloc: prefer the the original page's node for
 compressed data

Nhat Pham wrote:
> On Wed, Apr 2, 2025 at 2:41 PM Dan Williams <dan.j.williams@...el.com> wrote>
> >
> > Why do the work to pass in @nid only to hardcode 0 to
> > alloc_pages_node()?
> 
> That 0 is the order, i.e we want a single page here :)
> 
> The node id is the first argument of alloc_pages_node. I made the same
> mistake in one of the earlier versions of this patch series (which,
> fortunately I did not send out) - hopefully this time I'm correct :)

Oops, sorry for the noise. My eyes were so trained on @nid as the final
argument in all the other conversions that I overlooked that.

You can add:

Acked-by: Dan Williams <dan.j.williams@...el.com>