linux-kernel - Re: [PATCH v2] zsmalloc: prefer the the original page's node for compressed data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKEwX=PBp4i4DmCf_7r+Sk6ekB9ckgZEpuR-x4f0CTc00-d+BQ@mail.gmail.com>
Date: Wed, 2 Apr 2025 14:51:28 -0700
From: Nhat Pham <nphamcs@...il.com>
To: Dan Williams <dan.j.williams@...el.com>
Cc: akpm@...ux-foundation.org, hannes@...xchg.org, yosry.ahmed@...ux.dev, 
	chengming.zhou@...ux.dev, sj@...nel.org, linux-mm@...ck.org, 
	kernel-team@...a.com, linux-kernel@...r.kernel.org, gourry@...rry.net, 
	ying.huang@...ux.alibaba.com, jonathan.cameron@...wei.com, 
	linux-cxl@...r.kernel.org, minchan@...nel.org, senozhatsky@...omium.org
Subject: Re: [PATCH v2] zsmalloc: prefer the the original page's node for
 compressed data

On Wed, Apr 2, 2025 at 2:41 PM Dan Williams <dan.j.williams@...el.com> wrote>
>
> Why do the work to pass in @nid only to hardcode 0 to
> alloc_pages_node()?

That 0 is the order, i.e we want a single page here :)

The node id is the first argument of alloc_pages_node. I made the same
mistake in one of the earlier versions of this patch series (which,
fortunately I did not send out) - hopefully this time I'm correct :)