linux-kernel - RE: [PATCH v14 6/6] firmware: drivers: imx: adds miscdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <AM9PR04MB860417C363F5FEE2E024DCF595AF2@AM9PR04MB8604.eurprd04.prod.outlook.com>
Date: Wed, 2 Apr 2025 06:19:36 +0000
From: Pankaj Gupta <pankaj.gupta@....com>
To: Frank Li <frank.li@....com>
CC: Jonathan Corbet <corbet@....net>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v14 6/6] firmware: drivers: imx: adds miscdev

>> diff drivers/firmware/imx/ele_common.c
...
>> +			err = -EPERM;
>> +			goto exit;
>> +		}
>> +	}
>> +	set_se_rcv_msg_timeout(SE_RCV_MSG_LONG_TIMEOUT);

> you set default TIMEMOUT at suspend, but set LONG TIMEOUT here.
> What's happen, if one instance already resumed, and set
SE_RCV_MSG_LONG_TIMEOUT
> the other instance still in suspend, which will wrong use
SE_RCV_MSG_LONG_TIMEOUT.

You are correct. Since the interface is single here. It is not a problem.
For multiple interfaces, It is required to be put in priv structure.
Will update this in v15.

>> +
>> +	err = ele_msg_send_rcv(dev_ctx,
>> +			       tx_msg,
>> +			       cmd_snd_rcv_rsp_info.tx_buf_sz,
>> +			       rx_msg,

>> a/drivers/firmware/imx/se_ctrl.c b/drivers/firmware/imx/se_ctrl.c 
>> index 144a727bbfe0..9dbe866b7b13 100644
>> --- a/drivers/firmware/imx/se_ctrl.c

>> +char *get_se_if_name(u8 se_if_id)
>> +{
>> +	switch (se_if_id) {
>> +	case SE_TYPE_ID_DBG: return SE_TYPE_STR_DBG;
>> +	case SE_TYPE_ID_HSM: return SE_TYPE_STR_HSM;

> If only use once, needn't define macro, just
>	return "dbg".

It will be used multiple times in coming patches.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (11094 bytes)