linux-kernel - Re: [PATCH v6 2/6] mux: gpio: add optional regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-zvuhz2nkA5j4RZ@hovoldconsulting.com>
Date: Wed, 2 Apr 2025 10:05:14 +0200
From: Johan Hovold <johan@...nel.org>
To: srinivas.kandagatla@...aro.org
Cc: peda@...ntia.se, broonie@...nel.org, andersson@...nel.org,
	krzk+dt@...nel.org, ivprusov@...utedevices.com,
	luca.ceresoli@...tlin.com, zhoubinbin@...ngson.cn,
	paulha@...nsource.cirrus.com, lgirdwood@...il.com, robh@...nel.org,
	conor+dt@...nel.org, konradybcio@...nel.org, perex@...ex.cz,
	tiwai@...e.com, dmitry.baryshkov@....qualcomm.com,
	linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	johan+linaro@...nel.org,
	Christopher Obbard <christopher.obbard@...aro.org>
Subject: Re: [PATCH v6 2/6] mux: gpio: add optional regulator support

On Thu, Mar 27, 2025 at 10:06:29AM +0000, Srinivas Kandagatla wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> Some of the external muxes needs powering up using a regulator.
> This is the case with Lenovo T14s laptop which has a external audio mux
> to handle US/EURO headsets.
> 
> Add support to the driver to handle this optional regulator.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Tested-by: Christopher Obbard <christopher.obbard@...aro.org>

> @@ -82,6 +83,10 @@ static int mux_gpio_probe(struct platform_device *pdev)
>  		mux_chip->mux->idle_state = idle_state;
>  	}
>  
> +	ret = devm_regulator_get_enable_optional(dev, "mux");
> +	if (ret && ret != -ENODEV)
> +		return dev_err_probe(dev, ret, "Couldn't retrieve/enable gpio mux supply\n");

nit: "failed to get/enable mux supply" may be more consistent with the
other (non-capitalised error) messages and avoids repeating "gpio mux"
which will be added by driver core.

> +
>  	ret = devm_mux_chip_register(dev, mux_chip);
>  	if (ret < 0)
>  		return ret;

Either way:

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
Tested-by: Johan Hovold <johan+linaro@...nel.org>