linux-kernel - Re: [PATCH] PCI: rcar-gen4: set ep BAR4 fixed size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53inwqbz7faoat5pwngx2rqgygt2ksg7yfjqkltxtde3jattvx@t2fdptqivmcn>
Date: Wed, 2 Apr 2025 13:35:57 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Jerome Brunet <jbrunet@...libre.com>
Cc: Marek Vasut <marek.vasut+renesas@...il.com>, 
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, Rob Herring <robh@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Serge Semin <fancer.lancer@...il.com>, 
	Krzysztof Wilczyński <kwilczynski@...nel.org>, linux-pci@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Yuya Hamamachi <yuya.hamamachi.sx@...esas.com>
Subject: Re: [PATCH] PCI: rcar-gen4: set ep BAR4 fixed size

On Fri, Mar 28, 2025 at 03:30:44PM +0100, Jerome Brunet wrote:
> On rcar-gen4, the ep BAR4 has a fixed size of 256B.
> Document this constraint in the epc features of the platform.
> 
> Fixes: e311b3834dfa ("PCI: rcar-gen4: Add endpoint mode support")
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

- Mani

> ---
> This was tested on rcar-gen4 r8a779f0-spider device.
> ---
>  drivers/pci/controller/dwc/pcie-rcar-gen4.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> index fc872dd35029c083da58144dce23cd1ce80f9374..02638ec442e7012d61dfad70016077d9becf56a6 100644
> --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> @@ -403,6 +403,7 @@ static const struct pci_epc_features rcar_gen4_pcie_epc_features = {
>  	.msix_capable = false,
>  	.bar[BAR_1] = { .type = BAR_RESERVED, },
>  	.bar[BAR_3] = { .type = BAR_RESERVED, },
> +	.bar[BAR_4] = { .type = BAR_FIXED, .fixed_size = 256 },
>  	.bar[BAR_5] = { .type = BAR_RESERVED, },
>  	.align = SZ_1M,
>  };
> 
> ---
> base-commit: dea140198b846f7432d78566b7b0b83979c72c2b
> change-id: 20250328-rcar-gen4-bar4-dccd1347fe38
> 
> Best regards,
> -- 
> Jerome
> 

-- 
மணிவண்ணன் சதாசிவம்