[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250402011523.2271768-1-zhengqixing@huaweicloud.com>
Date: Wed, 2 Apr 2025 09:15:23 +0800
From: Zheng Qixing <zhengqixing@...weicloud.com>
To: song@...nel.org,
yukuai3@...wei.com
Cc: linux-raid@...r.kernel.org,
linux-kernel@...r.kernel.org,
yi.zhang@...wei.com,
yangerkun@...wei.com,
zhengqixing@...wei.com
Subject: [PATCH] md/md-bitmap: fix stats collection for external bitmaps
From: Zheng Qixing <zhengqixing@...wei.com>
The bitmap_get_stats() function incorrectly returns -ENOENT for external
bitmaps, preventing statistics collection when a valid superblock page
exists.
Remove the external bitmap check as the statistics should be available
regardless of bitmap storage location when sb_page is present.
Note: "bitmap_info.external" here refers to a bitmap stored in a separate
file (bitmap_file), not to external metadata.
Fixes: 8d28d0ddb986 ("md/md-bitmap: Synchronize bitmap_get_stats() with bitmap lifetime")
Signed-off-by: Zheng Qixing <zhengqixing@...wei.com>
---
drivers/md/md-bitmap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
index 44ec9b17cfd3..afd01c93ddd9 100644
--- a/drivers/md/md-bitmap.c
+++ b/drivers/md/md-bitmap.c
@@ -2357,8 +2357,6 @@ static int bitmap_get_stats(void *data, struct md_bitmap_stats *stats)
if (!bitmap)
return -ENOENT;
- if (bitmap->mddev->bitmap_info.external)
- return -ENOENT;
if (!bitmap->storage.sb_page) /* no superblock */
return -EINVAL;
sb = kmap_local_page(bitmap->storage.sb_page);
--
2.39.2
Powered by blists - more mailing lists