linux-kernel - Re: [PATCH] md/md-bitmap: fix stats collection for external bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15c25e4f-97d1-a517-fcce-8ae4c87ef2ef@huaweicloud.com>
Date: Thu, 3 Apr 2025 09:53:15 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Zheng Qixing <zhengqixing@...weicloud.com>, song@...nel.org
Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
 yi.zhang@...wei.com, yangerkun@...wei.com, zhengqixing@...wei.com,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] md/md-bitmap: fix stats collection for external bitmaps

Hi,

在 2025/04/02 9:15, Zheng Qixing 写道:
> From: Zheng Qixing <zhengqixing@...wei.com>
> 
> The bitmap_get_stats() function incorrectly returns -ENOENT for external
> bitmaps, preventing statistics collection when a valid superblock page
> exists.
> 
> Remove the external bitmap check as the statistics should be available
> regardless of bitmap storage location when sb_page is present.
> 
> Note: "bitmap_info.external" here refers to a bitmap stored in a separate
> file (bitmap_file), not to external metadata.
> 
> Fixes: 8d28d0ddb986 ("md/md-bitmap: Synchronize bitmap_get_stats() with bitmap lifetime")
> Signed-off-by: Zheng Qixing <zhengqixing@...wei.com>
> ---
>   drivers/md/md-bitmap.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
> index 44ec9b17cfd3..afd01c93ddd9 100644
> --- a/drivers/md/md-bitmap.c
> +++ b/drivers/md/md-bitmap.c
> @@ -2357,8 +2357,6 @@ static int bitmap_get_stats(void *data, struct md_bitmap_stats *stats)
>   
>   	if (!bitmap)
>   		return -ENOENT;
> -	if (bitmap->mddev->bitmap_info.external)
> -		return -ENOENT;
>   	if (!bitmap->storage.sb_page) /* no superblock */
>   		return -EINVAL;

bitmap_file doesn't have sb, so above condition still need to be fixed.

Thanks,
Kuai

>   	sb = kmap_local_page(bitmap->storage.sb_page);
>