linux-kernel - Re: [PATCH 1/3] staging: rtl8723bs: Use true/false instead of 1/0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72eb7f-52ce-60f5-6c56-52c644084f7@inria.fr>
Date: Wed, 2 Apr 2025 14:54:08 +0200 (CEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Erick Karanja <karanja99erick@...il.com>
cc: gregkh@...uxfoundation.org, outreachy@...ts.linux.dev, 
    philipp.g.hortmann@...il.com, linux-staging@...ts.linux.dev, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: Use true/false instead of 1/0

You have three patches with the same subject line, which is not allowed.
You can be more specific about the files name or the structure name and
field.

julia

On Wed, 2 Apr 2025, Erick Karanja wrote:

> Standardize boolean representation by replacing 1/0
> with true/false in cases where boolean logic is implied.
> This improves code clarity and aligns with the kernel’s bool type usage.
>
> Signed-off-by: Erick Karanja <karanja99erick@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index d46a04b9a05e..199727f04516 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -386,10 +386,10 @@ void update_bmc_sta(struct adapter *padapter)
>
>  		pmlmeinfo->FW_sta_info[psta->mac_id].psta = psta;
>
> -		psta->qos_option = 0;
> +		psta->qos_option = false;
>  		psta->htpriv.ht_option = false;
>
> -		psta->ieee8021x_blocked = 0;
> +		psta->ieee8021x_blocked = false;
>
>  		memset((void *)&psta->sta_stats, 0, sizeof(struct stainfo_stats));
>
> @@ -1967,17 +1967,17 @@ void sta_info_update(struct adapter *padapter, struct sta_info *psta)
>
>  	/* update wmm cap. */
>  	if (WLAN_STA_WME & flags)
> -		psta->qos_option = 1;
> +		psta->qos_option = true;
>  	else
> -		psta->qos_option = 0;
> +		psta->qos_option = false;
>
>  	if (pmlmepriv->qospriv.qos_option == 0)
> -		psta->qos_option = 0;
> +		psta->qos_option = false;
>
>  	/* update 802.11n ht cap. */
>  	if (WLAN_STA_HT & flags) {
>  		psta->htpriv.ht_option = true;
> -		psta->qos_option = 1;
> +		psta->qos_option = true;
>  	} else {
>  		psta->htpriv.ht_option = false;
>  	}
> --
> 2.43.0
>
>
>