linux-kernel - Re: [PATCH 2/3] staging: rtl8723bs: Use true/false instead of 1/0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40862a76-94bb-bf75-c3ee-8042404ea235@inria.fr>
Date: Wed, 2 Apr 2025 14:54:58 +0200 (CEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Erick Karanja <karanja99erick@...il.com>
cc: gregkh@...uxfoundation.org, outreachy@...ts.linux.dev, 
    philipp.g.hortmann@...il.com, linux-staging@...ts.linux.dev, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] staging: rtl8723bs: Use true/false instead of 1/0



On Wed, 2 Apr 2025, Erick Karanja wrote:

> Standardize boolean representation by replacing 1/0
> with true/false in cases where boolean logic is implied.
> This improves code clarity and aligns with the kernel’s bool type usage.

It would be nice to point out that true/false is used elsewhere in this
file for this structure field.  We can't see this in the patch.

julia

>
> Signed-off-by: Erick Karanja <karanja99erick@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 952ce6dd5af9..8f2c9c3e853c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -1173,7 +1173,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
>
>  	/*  check if there is WMM IE & support WWM-PS */
>  	pstat->flags &= ~WLAN_STA_WME;
> -	pstat->qos_option = 0;
> +	pstat->qos_option = false;
>  	pstat->qos_info = 0;
>  	pstat->has_legacy_ac = true;
>  	pstat->uapsd_vo = 0;
> @@ -1189,7 +1189,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
>
>  					pstat->flags |= WLAN_STA_WME;
>
> -					pstat->qos_option = 1;
> +					pstat->qos_option = true;
>  					pstat->qos_info = *(p+8);
>
>  					pstat->max_sp_len = (pstat->qos_info>>5)&0x3;
> --
> 2.43.0
>
>
>