linux-kernel - Re: [PATCH linux-next 1/5] phy: allwinner: phy-sun50i-usb3: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2773791.mvXUDI8C0e@jernej-laptop>
Date: Thu, 03 Apr 2025 19:39:24 +0200
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: vkoul@...nel.org, robert.marko@...tura.hr, shao.mingyin@....com.cn
Cc: kishon@...nel.org, wens@...e.org, samuel@...lland.org,
 zhang.enpei@....com.cn, linux-phy@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-kernel@...r.kernel.org, luka.perkov@...tura.hr,
 linux-arm-msm@...r.kernel.org, heiko@...ech.de,
 linux-rockchip@...ts.infradead.org, yang.yang29@....com.cn,
 xu.xin16@....com.cn, ye.xingchen@....com.cn
Subject:
 Re: [PATCH linux-next 1/5] phy: allwinner: phy-sun50i-usb3: Use
 dev_err_probe()

Dne sreda, 2. april 2025 ob 13:42:03 Srednjeevropski poletni čas je shao.mingyin@....com.cn napisal(a):
> From: Zhang Enpei <zhang.enpei@....com.cn>
> 
> Replace the open-code with dev_err_probe() to simplify the code.
> 
> Signed-off-by: Zhang Enpei <zhang.enpei@....com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn>

Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
>  drivers/phy/allwinner/phy-sun50i-usb3.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
> index 363f9a0df503..b03faffc160d 100644
> --- a/drivers/phy/allwinner/phy-sun50i-usb3.c
> +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
> @@ -141,11 +141,9 @@ static int sun50i_usb3_phy_probe(struct platform_device *pdev)
>  		return -ENOMEM;
> 
>  	phy->clk = devm_clk_get(dev, NULL);
> -	if (IS_ERR(phy->clk)) {
> -		if (PTR_ERR(phy->clk) != -EPROBE_DEFER)
> -			dev_err(dev, "failed to get phy clock\n");
> -		return PTR_ERR(phy->clk);
> -	}
> +	if (IS_ERR(phy->clk))
> +		return dev_err_probe(dev, PTR_ERR(phy->clk),
> +				     "failed to get phy clock\n");
> 
>  	phy->reset = devm_reset_control_get(dev, NULL);
>  	if (IS_ERR(phy->reset)) {
>