linux-kernel - Re: [GIT PULL] vfs mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250403-auferlegen-erzwang-a7ee009ea96d@brauner>
Date: Thu, 3 Apr 2025 21:45:59 +0200
From: Christian Brauner <brauner@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Leon Romanovsky <leon@...nel.org>, pr-tracker-bot@...nel.org, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] vfs mount

On Thu, Apr 03, 2025 at 12:18:45PM -0700, Linus Torvalds wrote:
> On Thu, 3 Apr 2025 at 11:25, Leon Romanovsky <leon@...nel.org> wrote:
> > >
> > > -     scoped_guard(rwsem_read, &namespace_sem)
> > > +     guard(rwsem_read, &namespace_sem);
> >
> > I'm looking at Linus's master commit a2cc6ff5ec8f ("Merge tag
> > 'firewire-updates-6.15' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394")
> > and guard is declared as macro which gets only one argument: include/linux/cleanup.h
> >   318 #define guard(_name) \
> >   319         CLASS(_name, __UNIQUE_ID(guard))
> 
> Christian didn't test his patch, obviously.

Yes, I just sent this out as "I get why this happens." after my
screaming "dammit" moment. Sorry that I didn't make this clear. I had a
pretty strong "ffs" 10 minutes after I had waded through the overlayfs
code I added without being able to figure out how the fsck this could've
happened. In any case, there's the obviously correct version now sitting
in the tree and it's seen testing obviously.