linux-kernel - Re: [PATCH v2 14/19] mtd: spinand: Use more specific naming for the (quad) program load op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h63535ob.fsf@bootlin.com>
Date: Thu, 03 Apr 2025 12:23:00 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Santhosh Kumar K <s-k6@...com>,  Pratyush Yadav
 <pratyush@...nel.org>,  Michael Walle <michael@...le.cc>,  Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>,  Steam Lin <stlin2@...bond.com>,
  linux-mtd@...ts.infradead.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 14/19] mtd: spinand: Use more specific naming for the
 (quad) program load op

On 03/04/2025 at 11:00:46 +01, Tudor Ambarus <tudor.ambarus@...aro.org> wrote:

> On 4/3/25 10:19 AM, Miquel Raynal wrote:
>> SPI operations have been initially described through macros implicitly
>> implying the use of a single SPI SDR bus. Macros for supporting dual and
>> quad I/O transfers have been added on top, generally inspired by vendor
>> naming, followed by DTR operations. Soon we might see octal
>> and even octal DTR operations as well (including the opcode byte).
>> 
>> Let's clarify what the macro really means by describing the expected bus
>> topology in the (quad) program load macro name.
>> 
>> While at modifying it, better add the missing_ OP suffix to align with
>> all the other macros of the same kind.
>> 
>> Acked-by: Tudor Ambarus <tudor.ambarus@...aro.org>
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>
>
> I don't remember giving R-b on this, not seeing it on ml as well, so
> please drop it when applying.
>
> I used Acked-by and not R-b because I wanted to signify that I'm OK with
> the general idea of the patches and that I'm OK with them landing, but I
> may not have reviewed it as thoroughly as if a Reviewed-by: was
> provided. Please use only the tags that I sent. And if by mistake I sent
> both A-b and R-b, use just the latter. Thanks!

I use b4 for collecting tags, but yeah that's strange.

I will use your Acked-by here.