linux-kernel - Re: [PATCH v2 19/19] mtd: spinand: winbond: Add support for W35N02JW and W35N04JW chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875xjl352w.fsf@bootlin.com>
Date: Thu, 03 Apr 2025 12:35:51 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Santhosh Kumar K <s-k6@...com>,  Pratyush Yadav
 <pratyush@...nel.org>,  Michael Walle <michael@...le.cc>,  Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>,  Steam Lin <stlin2@...bond.com>,
  linux-mtd@...ts.infradead.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 19/19] mtd: spinand: winbond: Add support for
 W35N02JW and W35N04JW chips

On 03/04/2025 at 11:13:36 +01, Tudor Ambarus <tudor.ambarus@...aro.org> wrote:

> Hi, Miquel,
>
> On 4/3/25 10:19 AM, Miquel Raynal wrote:
>> These chips support single SPI, octal SPI and octal DDR SPI.
>> 
>> For now, only the SDR protocols are supported.
>> 
>> Tested with the W35N02JW variant, but the 04 one just has twice more
>> dies and is described in the same datasheet, so we can reasonably expect
>> that it will behave identically.
>> 
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>
>> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
>
> Checked patches 15-19 now, I'm ok with them. When applying, please
> substitute my Reviewed-by tag with Acked-by for patches from 7 to 21.
> I explained why in the reply of v2 14/19. Thanks.

Duly noted.

I checked the b4 log, I don't understand why it picked your R-by tag on
all these commits:

$ b4 trailers -Su
Finding code-review trailers for 22 commits...
Checking change-id "20250214-winbond-6-14-rc1-octal-6f7db6be0204"
Grabbing search results from lore.kernel.org
Analyzing 52 code-review messages
---
  + Acked-by: Tudor Ambarus <tudor.ambarus@...aro.org>
    https://lore.kernel.org/all/cdc38266-18a9-4eff-bdad-c88b316310b3@linaro.org
  + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>
    https://lore.kernel.org/all/4d36e51f-323c-451c-afeb-a6e378e3ed53@linaro.org
---
Press Enter to apply these trailers or Ctrl-C to abort
  mtd: spinand: Use more specific naming for the (dual output) read from cache ops
    + Acked-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✓ DKIM/linaro.org)
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: Use more specific naming for the (dual IO) read from cache ops
    + Acked-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✓ DKIM/linaro.org)
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: Use more specific naming for the (quad output) read from cache ops
    + Acked-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✓ DKIM/linaro.org)
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: Use more specific naming for the (quad IO) read from cache ops
    + Acked-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✓ DKIM/linaro.org)
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: Use more specific naming for the program execution op
    + Acked-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✓ DKIM/linaro.org)
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: Use more specific naming for the (single) program load op
    + Acked-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✓ DKIM/linaro.org)
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: Use more specific naming for the (quad) program load op
    + Acked-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✓ DKIM/linaro.org)
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: winbond: Rename DTR variants
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: winbond: Add support for W35N01JW in single mode
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: Define octal read from cache operations
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: winbond: Add octal read support
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: Define octal load to cache operations
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: winbond: Add octal program support
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
  mtd: spinand: winbond: Add support for W35N02JW and W35N04JW chips
    + Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org> (✗ DKIM/linaro.org)
---
Invoking git-filter-repo to update trailers.
New history written in 0.17 seconds...
Completely finished after 0.38 seconds.
Trailers updated.


Thanks,
Miquèl