linux-kernel - Re: [PATCH v1 4/5] gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-5rJDWaSJd58lTa@smile.fi.intel.com>
Date: Thu, 3 Apr 2025 14:04:04 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-gpio@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Mika Westerberg <westeri@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 4/5] gpiolib: acpi: Reuse struct acpi_gpio_params in
 struct acpi_gpio_lookup

On Thu, Apr 03, 2025 at 01:35:06PM +0300, Mika Westerberg wrote:
> On Wed, Apr 02, 2025 at 03:21:19PM +0300, Andy Shevchenko wrote:
> > Some of the contents of struct acpi_gpio_lookup repeats what we have
> > in the struct acpi_gpio_params. Reuse the latter in the former.

> > +	struct acpi_gpio_params par;
> 
> params is better name

It's been already used elsewhere in the code. Do you want renaming there as
well for consistency's sake?

...

> >  	struct acpi_gpio_lookup *lookup = data;
> > +	struct acpi_gpio_params *par = &lookup->par;
> 
> These are not changed I guess so can this be const?

They are, see below. So the answer, it can't.

But I will double check and add const where it makes sense.

...

> >  		if (lookup->info.quirks & ACPI_GPIO_QUIRK_ONLY_GPIOIO && gpioint)
> > -			lookup->index++;
> > +			par->crs_entry_index++;

E.g., ^^^

-- 
With Best Regards,
Andy Shevchenko