linux-kernel - Re: [PATCH] media: platform: rpi1-cfe: fix pad in call to get_mbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40f559cc-7d56-4e81-a6d8-6870d6df9fb5@ideasonboard.com>
Date: Thu, 3 Apr 2025 14:07:45 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Hans Verkuil <hverkuil@...all.nl>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Naushir Patuck <naush@...pberrypi.com>,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 linux-media@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: platform: rpi1-cfe: fix pad in call to
 get_mbus_config()

Hi,

On 25/02/2025 23:25, Cosmin Tanislav wrote:
> 
> 
> On 2/25/25 11:20 PM, Cosmin Tanislav wrote:
>> The source subdevice might be using a source pad not equal to 0.
>>
>> Use the already existing source_pad field of cfe.
>>
>> Fixes: e7bad98c205d ("media: v4l: Convert the users of 
>> v4l2_get_link_freq to call it on a pad")
> 
> I used the wrong Fixes tag, this is the correct one:
> Fixes: 6edb685abb2a ("media: raspberrypi: Add support for RP1-CFE")
> 
>> Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>
>> ---
>>   drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/ 
>> drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
>> index 69a5f23e7954..7db4fe5e0fd4 100644
>> --- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
>> +++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
>> @@ -1206,8 +1206,8 @@ static int cfe_start_streaming(struct vb2_queue 
>> *vq, unsigned int count)
>>       cfg_reg_write(cfe, MIPICFG_INTE,
>>                 MIPICFG_INT_CSI_DMA | MIPICFG_INT_PISP_FE);
>> -    ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config, 0,
>> -                   &mbus_config);
>> +    ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config,
>> +                   cfe->source_pad, &mbus_config);
>>       if (ret < 0 && ret != -ENOIOCTLCMD) {
>>           cfe_err(cfe, "g_mbus_config failed\n");
>>           goto err_clear_inte;
> 

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

Please send a v2 with corrected description.

  Tomi