linux-kernel - Re: [PATCH v1 1/1] media: i2c: ds90ub960: Remove of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-5tI_WVF2YQQ837@smile.fi.intel.com>
Date: Thu, 3 Apr 2025 14:12:35 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
	Jai Luthra <jai.luthra@...asonboard.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: ds90ub960: Remove of_node assignment

On Thu, Apr 03, 2025 at 02:01:40PM +0300, Tomi Valkeinen wrote:
> On 12/03/2025 19:41, Andy Shevchenko wrote:
> > Remove of_node assignment which duplicates fwnode in struct i2c_board_info.
> > In general drivers must not set both, it's quite confusing. The I²C core
> > will consider fwnode with a priority and of_node is subject to remove from
> > above mentioned data structure.

...

> >   	struct device *dev = &priv->client->dev;
> >   	struct ds90ub9xx_platform_data *ser_pdata = &rxport->ser.pdata;
> >   	struct i2c_board_info ser_info = {
> > -		.of_node = to_of_node(rxport->ser.fwnode),
> >   		.fwnode = rxport->ser.fwnode,
> >   		.platform_data = ser_pdata,
> >   	};
> 
> This sounds logical, but breaks the driver for me.

The above assignments are still confusing, but I think I understand what's
going on. You run on OF based environment and some code uses of_*() APIs
instead of fwnode ones. That's why the current implementation in the I²C core
doesn't work.

> I also couldn't find this documented and didn't immediately find this from
> the i2c core implementation side.

The current code does this:

	client->dev.of_node = of_node_get(info->of_node);
	client->dev.fwnode = info->fwnode;

when it should do something like device_set_node() instead.

> Or am I missing some patch (running on v6.14)?

Yeah, there is a series in the mailing list [1], but it has no comments and
no move so far...

TL;DR: it seems in this change is incomplete.

[1]: https://lore.kernel.org/r/20250312185137.4154173-1-andriy.shevchenko@linux.intel.com

-- 
With Best Regards,
Andy Shevchenko