linux-kernel - Re: [PATCH v1 1/1] media: i2c: ds90ub960: Remove of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e6599fd-0b79-430b-9e94-f731b60e1705@ideasonboard.com>
Date: Thu, 3 Apr 2025 14:01:40 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
 Jai Luthra <jai.luthra@...asonboard.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: ds90ub960: Remove of_node assignment

Hi,

On 12/03/2025 19:41, Andy Shevchenko wrote:
> Remove of_node assignment which duplicates fwnode in struct i2c_board_info.
> In general drivers must not set both, it's quite confusing. The I²C core
> will consider fwnode with a priority and of_node is subject to remove from
> above mentioned data structure.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/media/i2c/ds90ub960.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index 5dde8452739b..5afdbbad9ff4 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -1682,7 +1682,6 @@ static int ub960_rxport_add_serializer(struct ub960_data *priv, u8 nport)
>   	struct device *dev = &priv->client->dev;
>   	struct ds90ub9xx_platform_data *ser_pdata = &rxport->ser.pdata;
>   	struct i2c_board_info ser_info = {
> -		.of_node = to_of_node(rxport->ser.fwnode),
>   		.fwnode = rxport->ser.fwnode,
>   		.platform_data = ser_pdata,
>   	};

This sounds logical, but breaks the driver for me. I also couldn't find 
this documented and didn't immediately find this from the i2c core 
implementation side.

Or am I missing some patch (running on v6.14)?

  Tomi