linux-kernel - Re: [PATCH v4 3/8] x86/fpu/xstate: Add CET supervisor xfeature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-6VhlOOfNTK_2tL@gmail.com>
Date: Thu, 3 Apr 2025 16:04:54 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Dave Hansen <dave.hansen@...el.com>
Cc: "Chang S. Bae" <chang.seok.bae@...el.com>,
	Chao Gao <chao.gao@...el.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	tglx@...utronix.de, seanjc@...gle.com, pbonzini@...hat.com,
	peterz@...radead.org, rick.p.edgecombe@...el.com,
	weijiang.yang@...el.com, john.allen@....com, bp@...en8.de,
	xin3.li@...el.com, Maxim Levitsky <mlevitsk@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Mitchell Levy <levymitchell0@...il.com>,
	Samuel Holland <samuel.holland@...ive.com>,
	Aruna Ramakrishna <aruna.ramakrishna@...cle.com>,
	Vignesh Balasubramanian <vigbalas@....com>
Subject: Re: [PATCH v4 3/8] x86/fpu/xstate: Add CET supervisor xfeature
 support


* Dave Hansen <dave.hansen@...el.com> wrote:

> On 4/1/25 10:15, Chang S. Bae wrote:
> > In V3, you moved this patch further back to position 8 out of 10. Now,
> > in this version, you've placed it at position 3 out of 8.
> > 
> > This raises the question of whether you've fully internalized his advice.
> 
> Uh huh.
> 
> 1. Refactor/fix existing code
> 2. Add new infrastructure
> 3. Add new feature

The more detailed version is:

 - fix bugs
 - clean up code
 - refactor code
 - add new infrastructure
 - add new features

Or in general, the patches are basically hierarchy-sorted by the 
'utility/risk' factor to users, while removing net technological debt.

This is why *sometimes* we'll even do cleanups/refactoring before 
fixes: a fix can become lower-risk if it's on top of a cleaner code 
base.

Thanks,

	Ingo