linux-kernel - Re: [PATCH] RDMA/rxe: Fix null pointer dereference in ODP MR check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20551f6e-df87-460b-9927-70c93b8d6149@fujitsu.com>
Date: Thu, 3 Apr 2025 02:59:05 +0000
From: "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
To: Zhu Yanjun <yanjun.zhu@...ux.dev>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"zyjzyj2000@...il.com" <zyjzyj2000@...il.com>, "jgg@...pe.ca" <jgg@...pe.ca>,
	"leon@...nel.org" <leon@...nel.org>, "Daisuke Matsuda (Fujitsu)"
	<matsuda-daisuke@...itsu.com>, Shin'ichiro Kawasaki
	<shinichiro.kawasaki@....com>
Subject: Re: [PATCH] RDMA/rxe: Fix null pointer dereference in ODP MR check



On 02/04/2025 16:58, Zhu Yanjun wrote:
> 
> Previously I once discussed with Bob Pearson about the function names.

This is a frequently raised question, yet I have not discovered a definitive
coding style(Please let me know if you have). According to my understanding,
the common practice I adhere to is as follows:

- Functions utilized within a single file often do not require a prefix, as current situation.
- If a function is to be used across multiple files, I believe a prefix is essential.

Thanks
Zhijian

> Perhaps it is better to rename is_odp_mr to rxe_is_odp_mr?
> 
> Since sometimes we debug in rdma, with a lot of functions with the same name, it is difficult to recognize the modules that this function belongs to.
> 
> Thus, in rxe module, it is better to add rxe_ prefix to the function name. But anyway, this commit is fine.