linux-kernel - Re: [PATCH v2] staging: rtl8723bs: Use % 4096 instead of & 0xfff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025040547-vagrancy-imagines-384b@gregkh>
Date: Sat, 5 Apr 2025 09:22:11 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
Cc: julia.lawall@...ia.fr, andy@...nel.org, dan.carpenter@...aro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	outreachy@...ts.linux.dev
Subject: Re: [PATCH v2] staging: rtl8723bs: Use % 4096 instead of & 0xfff

On Sat, Apr 05, 2025 at 12:09:59AM +0000, Abraham Samuel Adekunle wrote:
> Replace the bitwise AND operator `&` with a modulo
> operator `%` and decimal number to make the upper limit visible
> and clear what the semantic of it is.

Eeek, no.  We all "know" what & means (it's a bit mask to handle the
issues involved), and we all do NOT know that % will do the same thing
at all.

So this just made things more difficult to maintain over time.

What tool suggested this type of change to be made to this driver and
these lines?

thanks,

greg k-h