linux-kernel - Re: [PATCH v9 9/9] locking: Switch to _irq_{disable,enable}() variants in cleanup guards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_6257D365DB7BACED49A32ED535ACE884CD09@qq.com>
Date: Sat,  5 Apr 2025 16:25:11 +0800
From: Guangbo Cui <2407018371@...com>
To: lyude@...hat.com
Cc: boqun.feng@...il.com,
	linux-kernel@...r.kernel.org,
	longman@...hat.com,
	mingo@...hat.com,
	peterz@...radead.org,
	rust-for-linux@...r.kernel.org,
	tglx@...utronix.de,
	will@...nel.org,
	2407018371@...com
Subject: Re: [PATCH v9 9/9] locking: Switch to _irq_{disable,enable}() variants in cleanup guards

>  include/linux/spinlock.h | 26 ++++++++++++--------------
>  1 file changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
> index 897114d60cfd4..764c9fd797d0e 100644
> --- a/include/linux/spinlock.h
> +++ b/include/linux/spinlock.h
> @@ -605,18 +605,17 @@ DEFINE_LOCK_GUARD_1(raw_spinlock_nested, raw_spinlock_t,
>  		      raw_spin_unlock(_T->lock))
>  
>  DEFINE_LOCK_GUARD_1(raw_spinlock_irq, raw_spinlock_t,
> -		      raw_spin_lock_irq(_T->lock),
> -		      raw_spin_unlock_irq(_T->lock))
> +		      raw_spin_lock_irq_disable(_T->lock),
> +		      raw_spin_unlock_irq_enable(_T->lock))
>  
> -DEFINE_LOCK_GUARD_1_COND(raw_spinlock_irq, _try, raw_spin_trylock_irq(_T->lock))
> +DEFINE_LOCK_GUARD_1_COND(raw_spinlock_irq, _try, raw_spin_trylock_irq_disable(_T->lock))
>  
>  DEFINE_LOCK_GUARD_1(raw_spinlock_irqsave, raw_spinlock_t,
> -		      raw_spin_lock_irqsave(_T->lock, _T->flags),
> -		      raw_spin_unlock_irqrestore(_T->lock, _T->flags),
> -		      unsigned long flags)
> +		      raw_spin_lock_irq_disable(_T->lock),
> +		      raw_spin_unlock_irq_enable(_T->lock))
>  
>  DEFINE_LOCK_GUARD_1_COND(raw_spinlock_irqsave, _try,
> -			   raw_spin_trylock_irqsave(_T->lock, _T->flags))
> +			   raw_spin_trylock_irq_disable(_T->lock))

It seems that the `raw_spin_trylock_irq_disable` function is missing from
spinlock_rt.h, which will lead to a build failure when compiling with 
PREEMPT_RT enabled.

Best regards,
Guangbo Cui