linux-kernel - Re: [PATCH v5] staging: rtl8723bs: Prevent duplicate NULL tests on a value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f19d199-9702-4829-a4a7-b1eada2adeda@stanley.mountain>
Date: Sat, 5 Apr 2025 17:58:32 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Julia Lawall <julia.lawall@...ia.fr>, outreachy@...ts.linux.dev,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] staging: rtl8723bs: Prevent duplicate NULL tests on a
 value

On Sat, Apr 05, 2025 at 02:21:42PM +0100, Abraham Samuel Adekunle wrote:
> When a value has been tested for NULL in an expression, a
> second NULL test on the same value in another expression
> is unnecessary when the value has not been assigned to NULL.
> 
> Remove unnecessary duplicate NULL tests on the same value
> that has previously been tested.
> 
> Found by Coccinelle.
> 
> Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
> ---

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter