linux-kernel - Re: [PATCH v5] staging: rtl8723bs: Prevent duplicate NULL tests on a value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8efaafd9-b01-c52f-4969-31628aa839a7@inria.fr>
Date: Sun, 6 Apr 2025 09:00:26 -0400 (EDT)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Samuel Abraham <abrahamadekunle50@...il.com>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, outreachy@...ts.linux.dev, 
    linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] staging: rtl8723bs: Prevent duplicate NULL tests on
 a value



On Sat, 5 Apr 2025, Samuel Abraham wrote:

> On Sat, Apr 5, 2025 at 2:30 PM Julia Lawall <julia.lawall@...ia.fr> wrote:
> >
> >
> >
> > On Sat, 5 Apr 2025, Abraham Samuel Adekunle wrote:
> >
> > > When a value has been tested for NULL in an expression, a
> > > second NULL test on the same value in another expression
> > > is unnecessary when the value has not been assigned to NULL.
> > >
> > > Remove unnecessary duplicate NULL tests on the same value
> > > that has previously been tested.
> > >
> > > Found by Coccinelle.
> >
> > The changes are found in the same way, but the code patterns are overall
> > quite different.  It could make sense to make separate patches for them.
> > Then you could make a log message that is really specialized to the code
> > in each patch and it would be easier for the reviewer to be convinced that
> > you have done the right thing.
>
> Thank you for the feedback Julia.
> Okay how about the versioning. Should I make it like a Patchset?
>
> Like [PATCH v6] with the cover letter and two patches, one for each code
> pattern?

Yes.  Just explain what you are doing.

julia