[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <59e8de49-30d8-4df0-9135-ecd43efc3686@gmail.com>
Date: Sun, 6 Apr 2025 15:25:20 +0300
From: Sergey Ryazanov <ryazanov.s.a@...il.com>
To: Wentao Liang <vulab@...as.ac.cn>, loic.poulain@....qualcomm.com,
johannes@...solutions.net
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, pabeni@...hat.com,
kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net,
andrew+netdev@...n.ch
Subject: Re: [PATCH net-next v3] net: wwan: Add error handling for
ipc_mux_dl_acb_send_cmds().
On 05.04.2025 14:52, Wentao Liang wrote:
> The ipc_mux_dl_acbcmd_decode() calls the ipc_mux_dl_acb_send_cmds(),
> but does not report the error if ipc_mux_dl_acb_send_cmds() fails.
> This makes it difficult to detect command sending failures. A proper
> implementation can be found in ipc_mux_dl_cmd_decode().
>
> Add error reporting to the call, logging an error message using dev_err()
> if the command sending fails.
>
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
> drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
> index bff46f7ca59f..478c9c8b638b 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
> +++ b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
> @@ -509,8 +509,11 @@ static void ipc_mux_dl_acbcmd_decode(struct iosm_mux *ipc_mux,
> return;
> }
> trans_id = le32_to_cpu(cmdh->transaction_id);
> - ipc_mux_dl_acb_send_cmds(ipc_mux, cmd, cmdh->if_id,
> - trans_id, cmd_p, size, false, true);
> + if (ipc_mux_dl_acb_send_cmds(ipc_mux, cmd, cmdh->if_id,
> + trans_id, cmd_p, size, false, true))
> + dev_err(ipc_mux->dev,
> + "if_id %d: cmd send failed",
> + cmdh->if_id);
> }
> }
Looks good. One nit pick. The full stop is not needed in the subject.
But I believe, this does not worth to resend the patch.
Reviewed-by: Sergey Ryazanov <ryazanov.s.a@...il.com>
Powered by blists - more mailing lists