linux-kernel - Re: [PATCH net-next v3] net: wwan: Add error handling for ipc_mux_dl_acb_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89f9194a-e7dd-423b-ae54-c082f42edf51@redhat.com>
Date: Tue, 8 Apr 2025 12:34:50 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Wentao Liang <vulab@...as.ac.cn>, m.chetan.kumar@...el.com,
 loic.poulain@...aro.org, ryazanov.s.a@...il.com, johannes@...solutions.net,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] net: wwan: Add error handling for
 ipc_mux_dl_acb_send_cmds().

On 4/5/25 1:52 PM, Wentao Liang wrote:
> The ipc_mux_dl_acbcmd_decode() calls the ipc_mux_dl_acb_send_cmds(),
> but does not report the error if ipc_mux_dl_acb_send_cmds() fails.
> This makes it difficult to detect command sending failures. A proper
> implementation can be found in ipc_mux_dl_cmd_decode().
> 
> Add error reporting to the call, logging an error message using dev_err()
> if the command sending fails.
> 
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>

This has been posted while net-next was still closed for the merged
window.

You should have waited for the 'net-next is open' announcement on the
ML, or checked the status page, see:

https://elixir.bootlin.com/linux/v6.13.7/source/Documentation/process/maintainer-netdev.rst#L35

in the interest of fairness towards those who correctly wait
for the tree to be open I will ask you to repost this again,
in a couple of days.

When reposting, you can retain the already collected tags.

Thanks!

Paolo