linux-kernel - Re: [PATCH v3 26/32] rtc: s5m: prepare for external regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <718c954a-055f-4fda-aaf5-1e7e6167f715@kernel.org>
Date: Sun, 6 Apr 2025 20:30:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Alim Akhtar <alim.akhtar@...sung.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Russell King <linux@...linux.org.uk>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Peter Griffin <peter.griffin@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
 linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rtc@...r.kernel.org
Subject: Re: [PATCH v3 26/32] rtc: s5m: prepare for external regmap

On 03/04/2025 10:59, André Draszik wrote:
> The Samsung S2MPG10 PMIC is not connected via I2C as this driver
> assumes, hence this driver's current approach of creating an I2C-based
> regmap doesn't work for it, and this driver should use the regmap
> provided by the parent (core) driver instead for that PMIC.
> 
> To prepare this driver for s2mpg support, restructure the code to only
> create a regmap if one isn't provided by the parent.
> 
> No functional changes, since the parent doesn't provide a regmap for
> any of the PMICs currently supported by this driver. Having this change
> separate will simply make the addition of S2MPG10 support more
> self-contained, without additional restructuring.
> 
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof