linux-kernel - Re: [PATCH v3 27/32] rtc: s5m: add support for S2MPG10 RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e91005a-28b0-4508-b576-5406f3e048e0@kernel.org>
Date: Sun, 6 Apr 2025 20:33:09 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Alim Akhtar <alim.akhtar@...sung.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Russell King <linux@...linux.org.uk>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Peter Griffin <peter.griffin@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
 linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rtc@...r.kernel.org
Subject: Re: [PATCH v3 27/32] rtc: s5m: add support for S2MPG10 RTC

On 03/04/2025 10:59, André Draszik wrote:
> Add support for Samsung's S2MPG10 PMIC RTC, which is similar to the
> existing PMIC RTCs supported by this driver.
> 
> S2MPG10 doesn't use I2C, so we expect the core driver to have created a
> regmap for us.
> 
> Additionally, it can be used for doing a cold-reset. If requested to do
> so (via DT), S2MPG10 is programmed with a watchdog configuration that
> will perform a full power cycle upon watchdog expiry.
> 
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
> ---
>  drivers/rtc/rtc-s5m.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
> index 86ccf666c68059408907c97f2647716ffaad10c6..0d8783577bab4f4ebe61050dbd68387d970773bd 100644
> --- a/drivers/rtc/rtc-s5m.c
> +++ b/drivers/rtc/rtc-s5m.c
> @@ -11,6 +11,7 @@
>  #include <linux/i2c.h>
>  #include <linux/bcd.h>
>  #include <linux/regmap.h>
> +#include <linux/reboot.h>

You just sorted the MFD headers in other patch, but here you break the
sorting.

For me patches resorting the addresses (as a separate patch) is churn,
but sure. If you do this however, it means you really believe that it is
worth to sort them, so you must keep that standard for all your further
patches in that series.

Rest is fine, so with this fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof