linux-kernel - Re: [PATCH v2] serial: sifive: Switch to nbcon console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250407123920.14443-1-ryotkkr98@gmail.com>
Date: Mon,  7 Apr 2025 21:39:20 +0900
From: Ryo Takakura <ryotkkr98@...il.com>
To: lkp@...el.com
Cc: alex@...ti.fr,
	aou@...s.berkeley.edu,
	bigeasy@...utronix.de,
	conor.dooley@...rochip.com,
	gregkh@...uxfoundation.org,
	jirislaby@...nel.org,
	john.ogness@...utronix.de,
	linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	linux-serial@...r.kernel.org,
	oe-kbuild-all@...ts.linux.dev,
	palmer@...belt.com,
	paul.walmsley@...ive.com,
	pmladek@...e.com,
	ryotkkr98@...il.com,
	samuel.holland@...ive.com,
	u.kleine-koenig@...libre.com
Subject: Re: [PATCH v2] serial: sifive: Switch to nbcon console

On Sun, 6 Apr 2025 08:48:12 +0800, kernel test robot wrote:
>kernel test robot noticed the following build warnings:
>
>[auto build test WARNING on tty/tty-testing]
>[also build test WARNING on tty/tty-next tty/tty-linus linus/master v6.14 next-20250404]
>[If your patch is applied to the wrong git tree, kindly drop us a note.
>And when submitting patch, we suggest to use '--base' as documented in
>https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
>url:    https://github.com/intel-lab-lkp/linux/commits/Ryo-Takakura/serial-sifive-Switch-to-nbcon-console/20250405-230051
>base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
>patch link:    https://lore.kernel.org/r/20250405145915.493173-1-ryotkkr98%40gmail.com
>patch subject: [PATCH v2] serial: sifive: Switch to nbcon console
>config: arm-randconfig-002-20250406 (https://download.01.org/0day-ci/archive/20250406/202504060816.EWk91sJS-lkp@intel.com/config)
>compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
>reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250406/202504060816.EWk91sJS-lkp@intel.com/reproduce)
>
>If you fix the issue in a separate patch/commit (i.e. not just a new version of
>the same patch/commit), kindly add following tags
>| Reported-by: kernel test robot <lkp@...el.com>
>| Closes: https://lore.kernel.org/oe-kbuild-all/202504060816.EWk91sJS-lkp@intel.com/
>
>All warnings (new ones prefixed by >>):
>
>>> drivers/tty/serial/sifive.c:155: warning: Function parameter or struct member 'console_line_ended' not described in 'sifive_serial_port'

Thank you for reporting.
I overlooked this... I'll add a description for it.

Sincerely,
Ryo Takakura

>vim +155 drivers/tty/serial/sifive.c
>
>45c054d0815b15 Paul Walmsley 2019-04-12  131  
>45c054d0815b15 Paul Walmsley 2019-04-12  132  /*
>45c054d0815b15 Paul Walmsley 2019-04-12  133   *
>45c054d0815b15 Paul Walmsley 2019-04-12  134   */
>45c054d0815b15 Paul Walmsley 2019-04-12  135  
>45c054d0815b15 Paul Walmsley 2019-04-12  136  /**
>180bb243de730c Lee Jones     2020-11-04  137   * struct sifive_serial_port - driver-specific data extension to struct uart_port
>45c054d0815b15 Paul Walmsley 2019-04-12  138   * @port: struct uart_port embedded in this struct
>45c054d0815b15 Paul Walmsley 2019-04-12  139   * @dev: struct device *
>45c054d0815b15 Paul Walmsley 2019-04-12  140   * @ier: shadowed copy of the interrupt enable register
>45c054d0815b15 Paul Walmsley 2019-04-12  141   * @baud_rate: UART serial line rate (e.g., 115200 baud)
>180bb243de730c Lee Jones     2020-11-04  142   * @clk: reference to this device's clock
>45c054d0815b15 Paul Walmsley 2019-04-12  143   * @clk_notifier: clock rate change notifier for upstream clock changes
>45c054d0815b15 Paul Walmsley 2019-04-12  144   *
>45c054d0815b15 Paul Walmsley 2019-04-12  145   * Configuration data specific to this SiFive UART.
>45c054d0815b15 Paul Walmsley 2019-04-12  146   */
>45c054d0815b15 Paul Walmsley 2019-04-12  147  struct sifive_serial_port {
>45c054d0815b15 Paul Walmsley 2019-04-12  148  	struct uart_port	port;
>45c054d0815b15 Paul Walmsley 2019-04-12  149  	struct device		*dev;
>45c054d0815b15 Paul Walmsley 2019-04-12  150  	unsigned char		ier;
>45c054d0815b15 Paul Walmsley 2019-04-12  151  	unsigned long		baud_rate;
>45c054d0815b15 Paul Walmsley 2019-04-12  152  	struct clk		*clk;
>45c054d0815b15 Paul Walmsley 2019-04-12  153  	struct notifier_block	clk_notifier;
>328ee9dbff3941 Ryo Takakura  2025-04-05  154  	bool			console_line_ended;
>45c054d0815b15 Paul Walmsley 2019-04-12 @155  };
>45c054d0815b15 Paul Walmsley 2019-04-12  156  
>
>-- 
>0-DAY CI Kernel Test Service
>https://github.com/intel/lkp-tests/wiki