linux-kernel - Re: [PATCH v2] serial: sifive: Switch to nbcon console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_e5rWcJKUh7eozw@pathway.suse.cz>
Date: Thu, 10 Apr 2025 14:29:33 +0200
From: Petr Mladek <pmladek@...e.com>
To: Ryo Takakura <ryotkkr98@...il.com>
Cc: alex@...ti.fr, aou@...s.berkeley.edu, bigeasy@...utronix.de,
	conor.dooley@...rochip.com, gregkh@...uxfoundation.org,
	jirislaby@...nel.org, john.ogness@...utronix.de, palmer@...belt.com,
	paul.walmsley@...ive.com, samuel.holland@...ive.com,
	u.kleine-koenig@...libre.com, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v2] serial: sifive: Switch to nbcon console

On Sat 2025-04-05 23:59:15, Ryo Takakura wrote:
> Add the necessary callbacks(write_atomic, write_thread, device_lock
> and device_unlock) and CON_NBCON flag to switch the sifive console
> driver to perform as nbcon console.
> 
> Both ->write_atomic() and ->write_thread() will check for console
> ownership whenever they are accessing registers.
> 
> The ->device_lock()/unlock() will provide the additional serilization
> necessary for ->write_thread() which is called from dedicated printing
> thread.
> 
> Signed-off-by: Ryo Takakura <ryotkkr98@...il.com>
> Reviewed-by: John Ogness <john.ogness@...utronix.de>

I do not have the hardware around so I could not test it.
But the code looks good. With the added comment (reported
by the robot):

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr